Split x86_64-apple builder into two #93862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Looks good other than the nit about deduplication. |
Mark-Simulacrum
force-pushed
the
apple-split
branch
from
b3d3b4a to
a023be9
Compare
|
@bors r=pietroalbini p=1 rollup I'm not entirely convinced about the duplication being bad -- it's already semi-duplicated across the dist-x86_64-apple builders as well, and seems a little hard to avoid as each one has its own slightly unique take regardless -- but the test builders I suppose could be seen as distinct. In the meantime it doesn't really hurt (edit: to deduplicate). |
|
📌 Commit a023be9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92242 (Erase regions before calculating layout for packed field capture) - rust-lang#93443 (Add comment on stable_hash_impl for OwnerNodes) - rust-lang#93742 (Drop rustc-docs from complete profile) - rust-lang#93852 (rustdoc: remove support for multi-query search) - rust-lang#93853 (Make all `hir::Map` methods consistently by-value) - rust-lang#93861 (Fix ICE if no trait assoc const eq) - rust-lang#93862 (Split x86_64-apple builder into two) - rust-lang#93864 (Remove ArchiveBuilder::update_symbols) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits out roughly 20-25 minutes of work, which should result in roughly parity with some of the other apple builders at approximately 2.2-2.4 hours per successful build.
r? @pietroalbini